Link exchanges work fine if you use editorial discretion regarding who you link to and if you get links from sites worth having links from. It shouldn’t be your only linkbuilding strategy though. People who say link exchanges don’t work aren’t very good at doing link exchanges.